Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR Allow Locator to be extended and config updated #218

Merged
merged 4 commits into from
Jan 29, 2020

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jan 21, 2020

No description provided.

@jsirish jsirish requested review from muskie9 and mak001 January 21, 2020 22:11
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #218 into 3.1 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                3.1     #218     +/-   ##
===========================================
+ Coverage     60.42%   60.52%   +0.1%     
  Complexity      105      105             
===========================================
  Files             7        7             
  Lines           379      380      +1     
===========================================
+ Hits            229      230      +1     
  Misses          150      150
Flag Coverage Δ Complexity Δ
#php 60.52% <100%> (+0.1%) 105 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/pages/Locator.php 88.23% <100%> (ø) 22 <0> (ø) ⬇️
src/pages/LocatorController.php 52.63% <100%> (+0.35%) 35 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de9005...493aa11. Read the comment docs.

@jsirish
Copy link
Member Author

jsirish commented Jan 22, 2020

Tests well on a vanilla install

Screen Shot 2020-01-21 at 6 26 43 PM

@jsirish jsirish merged commit b0bdf63 into dynamic:3.1 Jan 29, 2020
@jsirish jsirish deleted the refactor/extendLocatorConfig branch January 29, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant